chore: update deploy actions #190
Merged
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment workflow to add release tagging automation and improve artifact uploading by passing tag information between jobs.
- Added job outputs to the
tag-releasejob to expose version and tag information to downstream jobs - Implemented tag existence checking to prevent duplicate tags from being created
- Modified the
upload-releasejob to accept and use the tag name from thetag-releasejob
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
.github/workflows/deploy.yml |
Added outputs to tag-release job, implemented tag existence check, added conditional tagging, and passed tag to upload-release job |
.github/workflows/upload-artifacts.yml |
Added tag_name input parameter and configured artifact upload to use the provided tag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Owner
Author
|
@copilot Please repeat your review of this code to ensure that it is syntactically and semantically correct. |
Contributor
Contributor
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
lstein
force-pushed
the
chore/fix-deploy-workflows
branch
from
3e091fc to
cb4e264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment workflow to improve release tagging and artifact uploading automation. The main changes ensure that releases are consistently tagged, prevent duplicate tags, and pass the tag name through the workflow for artifact uploads.
Release Tagging Improvements
tag-releasejob, and to check if the tag already exists before creating a new one, preventing duplicate tags. (.github/workflows/deploy.yml) [1] [2]Artifact Upload Automation
upload-releasejob to depend on thetag-releasejob and to pass the generated tag name as an input to the artifact upload workflow, ensuring artifacts are correctly attached to the release tag. (.github/workflows/deploy.yml,.github/workflows/upload-artifacts.yml) [1] [2]tag_nameinput when uploading release artifacts, ensuring they are associated with the correct release tag. (.github/workflows/upload-artifacts.yml)